Update Security_Containers/pihole/compose.yaml

Security_Containers/pihole/compose.yaml

@@ -3,18 +3,18 @@ services:
     container_name: pihole
     image: pihole/pihole:latest
     hostname: pihole
-    domainname: ${DOMAIN_NAME} # your local domain name
+    domainname: ${DOMAIN_NAME}
     #mac_address: de:ad:be:ef:ff:01 # can change or leave this
-    #cap_add: # only needed if doing DHCP
-     # - NET_ADMIN
+    cap_add: # only needed if doing DHCP
+      - NET_ADMIN
     restart: unless-stopped
     
     secrets:
       - piholepass
     
     networks:
-      pihole_network: # same as network specified below
-        ipv4_address: ${Pihole_IP} # the IP of the pihole container
+      pihole_network:
+        ipv4_address: ${Pihole_IP}
     
     dns:
       - 127.0.0.1 # use local DNS 
@@ -22,20 +22,20 @@ services:
     ports:
       - "53:53/tcp" #DNS
       - "53:53/udp" #DNS
-     #- "67:67/udp" #DHCP
+      - "67:67/udp" #DHCP
       - "80:80/tcp" #HTTP
       - "443:443/tcp" #HTTPS
     
-    volumes: # mount our data volumes.
+    volumes:
       - "/srv/docker/pihole/pihole:/etc/pihole"
       - "/srv/docker/pihole/dnsmasq.d:/etc/dnsmasq.d"
     
-    environment: # set variables for pihole configuration.
-      ServerIP: ${Pihole_IP} # must match ipv4_address above
+    environment:
+      ServerIP: ${Pihole_IP}
       FTLCONF_LOCAL_IPV4: ${Pihole_IP}
       PIHOLE_DNS_: ${Pihole_IP}
       DNSSEC: "false"
-      VIRTUAL_HOST: ${SERVICE_NAME}.${DOMAIN_NAME}  # Must be hostname + domainname from above
+      VIRTUAL_HOST: ${SERVICE_NAME}.${DOMAIN_NAME}
       #WEBPASSWORD: "randompassword"
       WEBPASSWORD_FILE: "/run/secrets/piholepass"
       TZ: "America/Chicago"
@@ -45,17 +45,6 @@ services:
       - flame.name=${SERVICE_NAME}
       - flame.url=https://${SERVICE_NAME}.${DOMAIN_NAME}/admin
       - flame.icon=https://cdn.jsdelivr.net/gh/homarr-labs/dashboard-icons/svg/pi-hole.svg
-      ### Enable Traefik
-      #- traefik.enable=true
-      #- traefik.docker.network=traefik_network
-      ### For HTTP
-      #- traefik.http.routers.${SERVICE_NAME}.rule=Host(`${SERVICE_NAME}.${DOMAIN_NAME}`)
-      #- traefik.http.routers.${SERVICE_NAME}.entrypoints=web
-      ### For HTTPS
-      #- traefik.http.routers.${SERVICE_NAME}-https.tls=true
-      #- traefik.http.routers.${SERVICE_NAME}-https.tls.certresolver=cloudflare
-      #- traefik.http.routers.${SERVICE_NAME}-https.entrypoints=websecure
-      #- traefik.http.routers.${SERVICE_NAME}-https.rule=Host(`${SERVICE_NAME}.${DOMAIN_NAME}`)
       ### Monitor with uptime-kuma
       - kuma.monitoring.group.name=Docker Containers
       - kuma.${SERVICE_NAME}.docker.parent_name=monitoring